----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53848/#review161860 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (lines 220 - 222) <https://reviews.apache.org/r/53848/#comment233139> I would change the parameter in `uri::docker::manifest` from tag to `reference`: ``` inline URI manifest( const std::string& repository, const std::string& reference, // Either tag or digest. const std::string& registry, const Option<std::string>& scheme = None(), const Option<int>& port = None()) ``` - Jie Yu On Nov. 28, 2016, 4:53 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53848/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 4:53 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-3505 > https://issues.apache.org/jira/browse/MESOS-3505 > > > Repository: mesos > > > Description > ------- > > For now we can only use digests to pull images that were pushed with > Docker 1.9 and older or from Registry 2.2.1 and older. Newer versions > use Schema 2 manifests that are not converted by the registry when > pulling by digest. > > > Diffs > ----- > > src/docker/spec.cpp 2f2c32e9b7d78debb31dcc1aa91a4d45c1ced192 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > b06ddff68a8d2df13abb838b03a8e73d4e273c31 > src/tests/containerizer/provisioner_docker_tests.cpp > 96821692a8b2080a25997afa66a0b5e6699c95c4 > src/uri/fetchers/docker.cpp 3f38dddfb4c089322fe4e13b1ef2070b4835885c > > Diff: https://reviews.apache.org/r/53848/diff/ > > > Testing > ------- > > Added a test to verify that an image that has V2 schema 1 manifest can be > pulled from the repository by digest. Ran `make check`. > > > Thanks, > > Ilya Pronin > >
