----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55740/ -----------------------------------------------------------
(Updated Jan. 20, 2017, 1:37 p.m.) Review request for mesos, Benjamin Bannier, Benjamin Hindman, and Benjamin Mahler. Repository: mesos Description (updated) ------- The `loop(...)` helper spawns a libprocess actor to execute some lambda (in a loop, of course). This actor is owned by the libprocess GC actor, but the body of the `loop` passes a copy of that pointer into a Future callback. This will potentially segfault if the actor terminates outside of the `loop`. Instead, the `loop` should use the `PID` of the actor. This change will make the `loop` code safer, just in case a future commit terminates the loop actor (such as the use of `process::finalize`). Diffs ----- 3rdparty/libprocess/include/process/loop.hpp 8bd9715246e72474a35a0f1af94c8a5a3e87dd7a Diff: https://reviews.apache.org/r/55740/diff/ Testing ------- make check Thanks, Joseph Wu
