> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote: > > src/webui/master/static/index.html, line 33 > > <https://reviews.apache.org/r/55770/diff/1/?file=1610638#file1610638line33> > > > > How about add class `.img-responsive` directly? > > Ilya Pronin wrote: > I tried, that didn't work :( > > haosdent huang wrote: > Oh, just realize the height value of `.navbar-header` is not match other > places. May you fix this by > > ``` > diff --git a/src/webui/master/static/css/mesos.css > b/src/webui/master/static/css/mesos.css > index 5077d45d8..75fc9d875 100644 > --- a/src/webui/master/static/css/mesos.css > +++ b/src/webui/master/static/css/mesos.css > @@ -11,6 +11,10 @@ > color: #FFF; > } > > +.navbar .navbar-header { > + height: 60px; > +} > + > .navbar .navbar-nav > li > a { > color: inherit; > padding-top: 20px; > ``` > > It fixes this problem as well. > > haosdent huang wrote: > Should be > > ``` > .navbar .navbar-header, > .navbar .navbar-brand { > height: 60px; > } > ```
Dropping the issue as discussed on Slack. - Ilya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55770/#review162428 ----------------------------------------------------------- On Jan. 20, 2017, 3:16 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55770/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 3:16 p.m.) > > > Review request for mesos, Benjamin Mahler and haosdent huang. > > > Bugs: MESOS-6963 > https://issues.apache.org/jira/browse/MESOS-6963 > > > Repository: mesos > > > Description > ------- > > Prevented the logo from stretching the navbar height making it > consistent with mobile version. > http://getbootstrap.com/components/#navbar-brand-image > > > Diffs > ----- > > src/webui/master/static/css/mesos.css > c817aaee0fd2d2579ff2e4a152d47e83ce80d68c > src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42 > > Diff: https://reviews.apache.org/r/55770/diff/ > > > Testing > ------- > > Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1. > > > Thanks, > > Ilya Pronin > >
