----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55548/#review162757 -----------------------------------------------------------
Fix it, then Ship it! src/tests/environment.cpp (line 30) <https://reviews.apache.org/r/55548/#comment234101> Won't need this if we use `foreach` instead below. src/tests/environment.cpp (line 802) <https://reviews.apache.org/r/55548/#comment234097> For consistency, let's use the helper from `stout/foreach.hpp` instead. - Joseph Wu On Jan. 15, 2017, 6:25 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55548/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 6:25 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This is necessary as a follow-up to r/5547, which removes > `os::raw::environment` from Stout's Windows API. > > > Diffs > ----- > > src/tests/environment.cpp a9e217e8beb5a6aca456ff5379893953cafca135 > > Diff: https://reviews.apache.org/r/55548/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
