----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55632/#review162898 -----------------------------------------------------------
cmake/MesosConfigure.cmake (line 40) <https://reviews.apache.org/r/55632/#comment234277> Let's leave this `ON`. The warning we get here is actually due to not setting any value for this variable. By default, `CMAKE_MACOSX_RPATH` is ON. And we don't have a good reason to change the default. - Joseph Wu On Jan. 17, 2017, 9:22 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55632/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 9:22 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > CMake: Disabled rpath to silence CMake warning on OS X. > > > Diffs > ----- > > cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc > > Diff: https://reviews.apache.org/r/55632/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
