----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55571/#review162915 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp (lines 2607 - 2613) <https://reviews.apache.org/r/55571/#comment234309> Is there a reason why we don't `LOG(INFO)` here and below? - Michael Park On Jan. 24, 2017, 4:34 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55571/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 4:34 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, Guangya Liu, and Michael > Park. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > This allows us to confirm that an updated FrameworkInfo is fully > compatible with an already known one. By performing this check in > updateFrameworkInfo when can be sure that both the new and old > FrameworkInfo are available (e.g., after framework reregistration, or > master or framework failover). > > > Diffs > ----- > > include/mesos/mesos.proto 044b7e697f77c9e2cefb938bda4307d328b33766 > include/mesos/v1/mesos.proto 7706de89d91926aedb10e4c882dffcf050f03bb1 > src/master/master.hpp 4bd01fd21820b7cdb6c2a23436d50e00fbbd5849 > src/master/master.cpp d2aee2b6e2a5da776c3b046a228d5ffcabd1bd54 > > Diff: https://reviews.apache.org/r/55571/diff/ > > > Testing > ------- > > Tested as part of https://reviews.apache.org/r/55271/. > > > Thanks, > > Benjamin Bannier > >
