----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55910/#review162998 -----------------------------------------------------------
Patch looks great! Reviews applied: [54842, 54836, 55825, 55826, 55827, 55829, 55828, 55863, 55866, 55824, 55868, 55908, 55909, 55910] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Jan. 25, 2017, 2:40 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55910/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 2:40 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Currently, a lof of code in the allocator makes use of the `[]` > operator to access the agents, frameworks and sorters, which > can lead to subtle bugs where insertion was unintended. > > With this change, a few const functions can be marked as such. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 9b66c23f26b37c02ed850c06c4518ea99078b02d > src/master/allocator/mesos/hierarchical.cpp > c2211be7458755aeb91ef078e4bfe92ac474044a > > Diff: https://reviews.apache.org/r/55910/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
