----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55955/#review163073 -----------------------------------------------------------
Bad patch! Reviews applied: [55955, 55954] Failed command: python support/apply-reviews.py -n -r 55954 Error: 2017-01-26 01:40:36 URL:https://reviews.apache.org/r/55954/diff/raw/ [5512/5512] -> "55954.patch" [1] error: src/health-check/health_checker.cpp: does not exist in index error: patch failed: src/master/validation.cpp:914 error: src/master/validation.cpp: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/16855/console - Mesos Reviewbot On Jan. 25, 2017, 8:13 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55955/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 8:13 p.m.) > > > Review request for mesos, Jan Schlicht and Vinod Kone. > > > Bugs: MESOS-6991 > https://issues.apache.org/jira/browse/MESOS-6991 > > > Repository: mesos > > > Description > ------- > > The `value` field within `Environment::Variable` is being > changed to `optional`, but for the time being we will > enforce that it must be set for backward compatibility. > This patch adds tests to ensure that environment variables > with unset values are correctly rejected. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4 > src/tests/master_validation_tests.cpp > a63178139a5283d6a3fcbe60c271dab1914e5da9 > > Diff: https://reviews.apache.org/r/55955/diff/ > > > Testing > ------- > > bin/mesos-tests.sh --gtest_filter="*Validation*" > > > Thanks, > > Greg Mann > >
