----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55868/#review163096 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 1870) <https://reviews.apache.org/r/55868/#comment234549> Any reason you want to update here? - Guangya Liu On 一月 24, 2017, 2:31 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55868/ > ----------------------------------------------------------- > > (Updated 一月 24, 2017, 2:31 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > This was necessary to greatly simplify the changes needed to the > allocator tests as we introduce support for multi-role frameworks. > > The main improvement here is to establish and use equality on the > `Allocation` struct, which makes the tests more readable and avoids > the manual probing of the allocation structure across all the tests. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5 > > Diff: https://reviews.apache.org/r/55868/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
