> On Jan. 24, 2017, 1:37 p.m., Joseph Wu wrote: > > src/health-check/tcp_connect.cpp, lines 33-38 > > <https://reviews.apache.org/r/55549/diff/1/?file=1605582#file1605582line33> > > > > Libprocess headers should go above stout headers. > > Alex Clemmer wrote: > Oh, did this change recently, or have I just always done this wrong?
You've gotten this right in the past. But it's easy to forget. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55549/#review162853 ----------------------------------------------------------- On Jan. 26, 2017, 12:45 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55549/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 12:45 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-6709 > https://issues.apache.org/jira/browse/MESOS-6709 > > > Repository: mesos > > > Description > ------- > > This is a blocker for MESOS-6709, which requires both the health checker > and the TCP connector to build and work on Windows. > > > Diffs > ----- > > src/checks/CMakeLists.txt ce195e2820c70dd7ebec1f06a6382f58fc729af7 > src/checks/health_checker.cpp e70bd7936752613a4f92c70c4c61cd7cdf7c4ee5 > src/checks/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9 > > Diff: https://reviews.apache.org/r/55549/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
