----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55829/#review163193 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Jan. 22, 2017, 6:09 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55829/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2017, 6:09 p.m.) > > > Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael > Park. > > > Bugs: MESOS-6965 > https://issues.apache.org/jira/browse/MESOS-6965 > > > Repository: mesos > > > Description > ------- > > Currently, `Resources::createStrippedScalarQuantity()` attempts to > create a notion of a "quantity" of resources. In order to do this, > all distinguishing metadata between resources of the same name are > stripped. This currently includes, disk metadata, reservation > metadata (only for dynamic reservations), and shared resource > metadata. To maintain the notion of a quantity, this patch also > strips the allocation metadata. > > > Diffs > ----- > > include/mesos/resources.hpp c2e6d6680d9687f0bbfb73e84ffb1457072c4412 > include/mesos/v1/resources.hpp 98f025b68c818c384a1174ef9b969f5c0776a7f1 > src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45 > src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 > src/v1/resources.cpp da4701c03020ff9c33ef995cd0af437d8827c267 > > Diff: https://reviews.apache.org/r/55829/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Benjamin Mahler > >
