----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55972/ -----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park. Bugs: MESOS-6968 https://issues.apache.org/jira/browse/MESOS-6968 Repository: mesos Description ------- With the addition of MULTI_ROLE framweork support, allocated resources have a `Resource.AllocationInfo` set. While the new MULTI_ROLE capable agents will be sending allocated resources, the old agents may not be since they may not preserve the unknown fields. To cope with this, the master ensures the `Resource.AllocationInfo` is set for non-MULTI_ROLE capable agents, by injecting it. Note that we can only do this so long as it is unambiguous! This will be prevented by not allowing frameworks with multiple to use agents without the MULTI_ROLE support, see: MESOS-6940. Diffs ----- src/master/master.hpp 7e38af41ca16241dbbe3bc2e80c0848e82762a45 src/master/master.cpp 0f2c7cd32161576fad742ef350dff64874b80854 Diff: https://reviews.apache.org/r/55972/diff/ Testing ------- The tests pass at the end of this review chain. Thanks, Benjamin Mahler