> On Jan. 19, 2017, 3:15 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2994-2998 > > <https://reviews.apache.org/r/51028/diff/6/?file=1590243#file1590243line2994> > > > > This test is already paused, all of these should be run with a paused > > clock, are any of them not?
Earlier in the test: // Allow the allocation timer to measure time. Clock::resume(); - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review162237 ----------------------------------------------------------- On Jan. 27, 2017, 2:33 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51028/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 2:33 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6904 > https://issues.apache.org/jira/browse/MESOS-6904 > > > Repository: mesos > > > Description > ------- > > - Per MESOS-3157, if cluster events with the possibility > of triggering an allocation occur rapidly and test > assertions depend on gleaning information from assumed > order, it is likely they will fail due to lack of parity > between event and actual allocation. Ensure that expected > allocations occur. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5 > > Diff: https://reviews.apache.org/r/51028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
