----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55970/#review163405 -----------------------------------------------------------
src/master/http.cpp (lines 4614 - 4615) <https://reviews.apache.org/r/55970/#comment234865> I think this can be replaced by the util function in below comments? src/master/quota_handler.cpp (lines 196 - 200) <https://reviews.apache.org/r/55970/#comment234864> Per the comments in /r/55870/ , how about move this to resources_utils.cpp? src/master/validation.cpp (lines 1654 - 1667) <https://reviews.apache.org/r/55970/#comment234867> Did not quite catch up the `TODO` here, can you please elaborate for why want such a function? src/master/validation.cpp (line 1718) <https://reviews.apache.org/r/55970/#comment234866> How about ``` if (unallocated(resources).contains(volume)) { ``` and then kill #1715 ? - Guangya Liu On 一月 26, 2017, 1:08 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55970/ > ----------------------------------------------------------- > > (Updated 一月 26, 2017, 1:08 a.m.) > > > Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael > Park. > > > Repository: mesos > > > Description > ------- > > With the addition of MULTI_ROLE framework support, allocated > resources in the master have `Resource.AllocationInfo` set. This > means that the master's http endpoints that apply operations or > perform checks between unallocated and allocated resources must > be updated to continue to function correctly. > > > Diffs > ----- > > src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 > src/master/quota_handler.cpp 6e6e7375219d34e6e8d011a025b5f5d70b87383b > src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 > > Diff: https://reviews.apache.org/r/55970/diff/ > > > Testing > ------- > > The existing tests pass at the end of this review chain. > > > Thanks, > > Benjamin Mahler > >
