----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55969/#review163684 -----------------------------------------------------------
Ship it! src/master/master.cpp (line 3668) <https://reviews.apache.org/r/55969/#comment235154> Let's use `foreach` here as well. src/master/master.cpp (lines 3669 - 3672) <https://reviews.apache.org/r/55969/#comment235156> Not sure if you took the suggestion to make `protobuf::adjustOfferOperation` be a mutating operation. If you did, this could be: ```cpp foreach (Offer::Operation& operation, *accept.mutable_operations()) { protobuf::adjustOfferOperation(operation, allocationInfo.get()); } ``` - Michael Park On Jan. 25, 2017, 5:05 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55969/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 5:05 p.m.) > > > Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael > Park. > > > Bugs: MESOS-6968 > https://issues.apache.org/jira/browse/MESOS-6968 > > > Repository: mesos > > > Description > ------- > > When communicating with non-MULTI_ROLE schedulers, the master > must inject the allocation info from the offer in order so that > the operations can be treated as consistently having allocation > info set. This is necessary when applying operations to allocated > resources that contain allocations to multiple roles (e.g. the > sum of allocated resources on an agent). > > > Diffs > ----- > > src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba > > Diff: https://reviews.apache.org/r/55969/diff/ > > > Testing > ------- > > Existing tests pass at the end of this review chain. > > > Thanks, > > Benjamin Mahler > >
