> On Jan. 31, 2017, 5:06 p.m., Guangya Liu wrote: > > src/tests/master_allocator_tests.cpp, lines 1751-1752 > > <https://reviews.apache.org/r/55852/diff/1/?file=1612985#file1612985line1751> > > > > This is only checking one offer but not two?
`framework2offers` is a `Queue`, calling [get()](https://github.com/apache/mesos/blob/d0f4cd4d9e98c27fd03eeafcef6e16bb04f51bc8/3rdparty/libprocess/include/process/queue.hpp#L55) on it repeatedly will pop out the elements. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55852/#review163762 ----------------------------------------------------------- On Jan. 31, 2017, 1:03 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55852/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 1:03 a.m.) > > > Review request for mesos, Guangya Liu and Jacob Janco. > > > Bugs: MESOS-6904 > https://issues.apache.org/jira/browse/MESOS-6904 > > > Repository: mesos > > > Description > ------- > > - This test is broken by the batched allocation change. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > 996762f25453f7a8a5e0b7b97006ee2a603cf8c4 > > Diff: https://reviews.apache.org/r/55852/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
