----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56053/ -----------------------------------------------------------
(Updated Feb. 1, 2017, 10:08 p.m.) Review request for mesos, Jan Schlicht and Vinod Kone. Changes ------- Addressed comments. Bugs: MESOS-7009 https://issues.apache.org/jira/browse/MESOS-7009 Repository: mesos Description ------- This patch adds a field of type `Secret` to the `Environment` protobuf message, enabling the passing of secrets into the environments of executors and tasks. Additional validation and test code is added as well. Diffs (updated) ----- include/mesos/mesos.proto a08b8fb2edf26ae730467557ae0e33e3d4252593 include/mesos/v1/mesos.proto 4a4609e7db659252ef7f1ca61f8ba079b901b7d0 src/common/validation.cpp b2548ad87b4227d6e498c49b5694acb362f6281b src/tests/check_tests.cpp c88cd34fd214f111cff62591aa5fc03eb62567e4 src/tests/health_check_tests.cpp 710cb66eff6c4447caa22772f0cdc97cfa582c50 src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8 src/tests/slave_validation_tests.cpp 5de771114982751e7796f55dcacd4384c6989efb Diff: https://reviews.apache.org/r/56053/diff/ Testing ------- `make check` Thanks, Greg Mann