----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56195/ -----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, and Jie Yu. Repository: mesos Description ------- Previously, if the containizer launch path failed before actually launching the container, the FDs allocated to the container by the IOSwitchboard isolator would be leaked. This would lead to deadlock in the destroy path because the IOSwitchboard does not shutdown until the FDs it allocates to the container have been closed. Since the switchboard doesn't shutdown, the future returned by its 'cleanup()' function is never satisfied. This commit makes sure to close the FDs under all failure cases in the launch path. Diffs ----- src/slave/containerizer/mesos/containerizer.cpp 4f0a773676da45fa40ad1ad9cdfab2a19249247d Diff: https://reviews.apache.org/r/56195/diff/ Testing ------- Tests still pending. WIll update when complete. Thanks, Kevin Klues
