----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/#review164183 -----------------------------------------------------------
src/launcher/default_executor.cpp (line 472) <https://reviews.apache.org/r/56270/#comment235810> s/pending/containerIds/ src/launcher/default_executor.cpp (line 493) <https://reviews.apache.org/r/56270/#comment235812> s/pending/containerIds/ src/launcher/default_executor.cpp (lines 686 - 725) <https://reviews.apache.org/r/56270/#comment235815> I'm wondering if it would be easier to grok if we locally generate a UUID for a task group and use that in the executor code. also, do we really need `killTaskGroups`? looks like we could just look in `killed/killing` to avoid killing a task multiple times? src/launcher/default_executor.cpp (line 1033) <https://reviews.apache.org/r/56270/#comment235809> you wouldn't need this if you key it on TaskID per my comment in the previous review. src/tests/default_executor_tests.cpp (lines 333 - 334) <https://reviews.apache.org/r/56270/#comment235820> move this to #391. src/tests/default_executor_tests.cpp (lines 340 - 341) <https://reviews.apache.org/r/56270/#comment235823> move this to #391. src/tests/default_executor_tests.cpp <https://reviews.apache.org/r/56270/#comment235824> i would keep the expectation here and ensure it is still pending after the first kill. - Vinod Kone On Feb. 3, 2017, 4:45 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56270/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 4:45 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6296 > https://issues.apache.org/jira/browse/MESOS-6296 > > > Repository: mesos > > > Description > ------- > > If a task fails or is explicitly killed by the scheduler, the > default on termination policy kills the particular task group. > The executor commits suicide when there are no active tasks. > > > Diffs > ----- > > src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 > src/tests/default_executor_tests.cpp > e8e0aa2f0d2508de6db03685c70d1ed9c1da3659 > > Diff: https://reviews.apache.org/r/56270/diff/ > > > Testing > ------- > > make check. Also, modified an existing test to launch/kill multiple task > groups. > > > Thanks, > > Anand Mazumdar > >
