> On Jan. 30, 2017, 10:26 a.m., Benjamin Bannier wrote: > > src/master/master.hpp, line 2448 > > <https://reviews.apache.org/r/56004/diff/1/?file=1617175#file1617175line2448> > > > > Not yours, but should likely be > > > > if (source.capabilities.empty()) { > > info.clear_capabilities(); > > } else { > > info.mutable_capabilities()->CopyFrom(source.capabilities()); > > }
Hm.. are you referring to the capabilities block below using empty instead of size? I suppose that piece could even just be: ``` info.mutable_capabilities()->CopyFrom(source.capabilities()); ``` Since it's a repeated field. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56004/#review163488 ----------------------------------------------------------- On Jan. 27, 2017, 12:30 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56004/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 12:30 a.m.) > > > Review request for mesos, Benjamin Bannier and Michael Park. > > > Repository: mesos > > > Description > ------- > > The first issue is that we need to update the capabilities member > to reflect the new capabilities. > > The second issue is that when we allow an upgrade or downgrade > to or from MULTI_ROLE, we need to update the `role` and `roles` > fields of `FrameworkInfo`. > > > Diffs > ----- > > src/master/master.hpp 7e38af41ca16241dbbe3bc2e80c0848e82762a45 > > Diff: https://reviews.apache.org/r/56004/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
