> On Feb. 3, 2017, 11:02 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 89 > > <https://reviews.apache.org/r/56269/diff/1/?file=1622928#file1622928line89> > > > > hmm. it's unfortunate that each task/container stores TaskInfos of all > > tasks in the task group. > > > > can we have a helper function instead that returns a list of container > > IDs that belong to the same task group as a given container? > > > > ``` > > hashset<ContainerID> taskGroupContainers(const ContainerID& > > containerId) {} > > ``` > > > > or store a shared pointer to TaskGroup?
We would only have a few limited active task groups at a time. So, shouldn't be that bad. This is also much easier to reason about. Otherwise, we would need to store the taskGroups in a separate hashmap and then clean them up when all the tasks in a task group terminate among other things. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56269/#review164181 ----------------------------------------------------------- On Feb. 4, 2017, 5:51 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56269/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2017, 5:51 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6296 > https://issues.apache.org/jira/browse/MESOS-6296 > > > Repository: mesos > > > Description > ------- > > This helps us in consolidating various metadata associatd with > an active child container. Also, this would be used in the future > for figuring out the task group corresponding to a child container > and then killing the other child containers belonging to the task > group when one of the tasks fail; or if a task in the task group > is explicitly killed by the scheduler. > > > Diffs > ----- > > src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 > > Diff: https://reviews.apache.org/r/56269/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
