----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55140/#review164264 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/oci_spec_tests.cpp (line 28) <https://reviews.apache.org/r/55140/#comment235930> Let's move this above 'using std::string' src/tests/containerizer/oci_spec_tests.cpp (line 39) <https://reviews.apache.org/r/55140/#comment235932> Why you need a JSON here? Can that just be a string? Ditto elsewhere in this file. - Jie Yu On Feb. 1, 2017, 1:14 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55140/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 1:14 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-6681 > https://issues.apache.org/jira/browse/MESOS-6681 > > > Repository: mesos > > > Description > ------- > > Added tests for parsing OCI image spec. > > > Diffs > ----- > > src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 > src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c > src/tests/containerizer/oci_spec_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/55140/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
