----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review164303 -----------------------------------------------------------
Ship it! I greatly appreciate the goal of maintaining the integrity of the POSIX code paths by minimizing the changes required to make them work. So, while I have very serious reservations about doing things like implementing a `<` operator semantics on something that ends up being a `HANDLE` under the hood, for now, I think this is good enough, and accomplishes the goals that are important to the project. - Alex Clemmer On Feb. 6, 2017, 1:04 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54591/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 1:04 a.m.) > > > Review request for mesos, Daniel Pravat and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > In POSIX the socket, pipe and a file are represented by the `int` type. > In Windows: > - A socket is kept in a `SOCKET` type (64 bit wide) > - A pipe or a WinAPI file descriptor in a `HANDLE` (64 bit wide) > - A CRT file descriptor in an `int` > > The `WindowsFD` class is a type that brings all of these things > together and behaves analogously to an `int` in POSIX. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 > 3rdparty/stout/include/stout/os.hpp > ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 > 3rdparty/stout/include/stout/os/int_fd.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/fd.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54591/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
