----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review164323 -----------------------------------------------------------
Fix it, then Ship it! I would fix these issues for you. Please take a look. Thanks a lot for your contribution! src/webui/master/static/index.html (line 48) <https://reviews.apache.org/r/53741/#comment236014> Nit: remove the extra space. ``` <li data-ng-class="{active: (navbarActiveTab === 'maintenance')}"> <a href="#/maintenance">Maintenance</a> </li> ``` src/webui/master/static/js/app.js (line 23) <https://reviews.apache.org/r/53741/#comment236015> Moved this after `framework` to keep alphabectically. ``` .when('/frameworks/:id', {templateUrl: 'static/framework.html', controller: 'FrameworkCtrl'}) .when('/maintenance', {templateUrl: 'static/maintenance.html', controller: 'MaintenanceCtrl'}) ``` src/webui/master/static/js/controllers.js (line 477) <https://reviews.apache.org/r/53741/#comment236016> ``` $http.jsonp('/master/maintenance/schedule?jsonp=JSON_CALLBACK') ``` src/webui/master/static/maintenance.html (lines 21 - 27) <https://reviews.apache.org/r/53741/#comment236018> Need to use the custom directives by this way. ``` <td> <m-timestamp value="{{window.unavailability.start.nanoseconds / 1000000}}"> </m-timestamp> </td> <td> <m-timestamp value="{{(window.unavailability.duration.nanoseconds + window.unavailability.start.nanoseconds) / 1000000}}"> </m-timestamp> </td> ``` src/webui/master/static/maintenance.html (line 30) <https://reviews.apache.org/r/53741/#comment236017> Nit: Indent should be 2. `` {{machine_ids.hostname ? machine_ids.hostname : machine_ids.ip}} ``` - haosdent huang On Feb. 6, 2017, 9:29 a.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53741/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 9:29 a.m.) > > > Review request for mesos, haosdent huang and Joseph Wu. > > > Bugs: MESOS-6443 > https://issues.apache.org/jira/browse/MESOS-6443 > > > Repository: mesos > > > Description > ------- > > Create new page with Maintenance schedule. Schedule is downloaded on > page refresh. Schedule is not live like stats and tasks so there is > no need to poll it periodically. > Diable sorting when data-key is not defined in table header. > > > Diffs > ----- > > src/webui/master/static/index.html 7c6a8ad56437c2315fc563d469ed0426286b48ce > src/webui/master/static/js/app.js 558a67ddf59a39db43023b4f7aa26b7e319924b0 > src/webui/master/static/js/controllers.js > 07bc612a4d7a6b4b418de964303e8fb7083b5d31 > src/webui/master/static/maintenance.html PRE-CREATION > > Diff: https://reviews.apache.org/r/53741/diff/ > > > Testing > ------- > > [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) > > Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 > entires schedule generated with > [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) > > > Thanks, > > Tomasz Janiszewski > >
