----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56352/ -----------------------------------------------------------
Review request for mesos and Michael Park. Repository: mesos Description ------- When an allocation is made to a client, we want to update the share and the count of allocations made to that client. This was previously done separately, resulting in two std::set lookups, removals, and reinsertions. By improving `DRFSorter::updateShare` to support incrementing the number of client-allocations, we can do both updates with a single sequence of std::set lookup/remove/insert operations. Diffs ----- src/master/allocator/sorter/drf/sorter.hpp 5bed53a1641fee0c09862f77b394a0e9ec131990 src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7 Diff: https://reviews.apache.org/r/56352/diff/ Testing ------- `make check` Running the sorter benchmarks with an optimized build, this results in a modest improvement (~10%). Thanks, Neil Conway
