-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56340/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 5:18 p.m.)
Review request for mesos, Jie Yu and Kevin Klues.
Changes
-------
Change a string in another validation test. The TaskGroup in that test is now
invalidated slightly earlier than before (and with a different string).
Bugs: MESOS-7027
https://issues.apache.org/jira/browse/MESOS-7027
Repository: mesos
Description
-------
The default executor used to launch TaskGroups is generated by the
agent. The agent generates the executor's `CommandInfo`, hence why
the user may not specify the `CommandInfo` in the `LAUNCH_TASK_GROUP`
call.
This commit adds similar restrictions for `ContainerInfo` plus the
default executor. The `CommandInfo` constructed by the agent expects
to be run in the same environment as the agent process. This commit
prevents the user from specifying a `DockerInfo` or a container image
along with the default executor.
If the user explicitly wants to use the default executor, they could
always package the default executor's binary and libraries into a
container and launch it like any other custom executor.
Diffs (updated)
-----
include/mesos/mesos.proto 53885cbc63ac6658a749da5e05bb2301392f84dd
include/mesos/v1/mesos.proto c4ca6dea787cfe4661c9f0d9afb770bceb1c2639
src/master/validation.cpp 2beee167439fe39d4f595c6b858fb6175321fbcd
src/tests/master_validation_tests.cpp
1f833aa8d6cacbd7bf502fb66c556e4e3d4f79e2
Diff: https://reviews.apache.org/r/56340/diff/
Testing (updated)
-------
src/mesos-tests --gtest_filter="ExecutorValidationTest.ExecutorType"
NOTE: The change to TaskGroupValidationTest.ExecutorUsesDockerContainerInfo is
because the tested case now fails during "general" validation of the
ExecutorInfo. We still need the checks around `Option<Error>
validateExecutor(TaskGroupInfo, ExecutorInfo, Framework*, Slave*, Resources)`
because those checks are valid for custom executors.
Thanks,
Joseph Wu
