----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review164424 -----------------------------------------------------------
src/checks/checker.hpp (line 60) <https://reviews.apache.org/r/56208/#comment236129> s/prior/prior to/ s/a check/the check/ src/checks/checker.hpp (line 71) <https://reviews.apache.org/r/56208/#comment236128> const & ? src/checks/checker.hpp (line 88) <https://reviews.apache.org/r/56208/#comment236130> Any reason why this is defined here instead of inside the cpp file? src/checks/checker.hpp (line 96) <https://reviews.apache.org/r/56208/#comment236131> const &? src/checks/checker.hpp (line 105) <https://reviews.apache.org/r/56208/#comment236144> s/performSingleCheck/performCheck/ ? similar to how you don't say `singleCommandCheck` or `singleHttpCheck` below src/checks/checker.hpp (line 126) <https://reviews.apache.org/r/56208/#comment236132> const? src/checks/checker.cpp (line 123) <https://reviews.apache.org/r/56208/#comment236140> extraneous back tick. src/checks/checker.cpp (line 141) <https://reviews.apache.org/r/56208/#comment236136> put it on the previous line? src/checks/checker.cpp (line 273) <https://reviews.apache.org/r/56208/#comment236146> is the equality operator defined for the above statement to be true? src/checks/checker.cpp (line 274) <https://reviews.apache.org/r/56208/#comment236145> i.e., src/checks/checker.cpp (line 300) <https://reviews.apache.org/r/56208/#comment236166> s/external/s/ like you did below for http check? - Vinod Kone On Feb. 2, 2017, 9:56 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56208/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 9:56 a.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > Add support for general checks, i.e. defined by CheckInfo, in > checking library. A general check can be either an command or > an HTTP request. The library performs the requested check at > the specified interval and sends the result to the framework > via a task status update. If the current result is the same as > the previous result, no status update is sent. > > > Diffs > ----- > > src/checks/checker.hpp dc293f3d3613dec716510d269829f8a6f406c277 > src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 > src/checks/health_checker.hpp 95da1ff7dd6b222a93076633eb3757ec9aa43cf6 > src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b > > Diff: https://reviews.apache.org/r/56208/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
