----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56368/#review164494 -----------------------------------------------------------
The declaration of `ParentHook::CREATE_JOB()` in `subprocess_base.hpp` should also be removed. - Ilya Pronin On Feb. 7, 2017, 2:31 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56368/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 2:31 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-6892 > https://issues.apache.org/jira/browse/MESOS-6892 > > > Repository: mesos > > > Description > ------- > > Libprocess: Windows: Remove `CREATE_JOB` parent hook. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess.cpp > bc1b99b8f84332f42623c35fc2b8d5186ba8af70 > > Diff: https://reviews.apache.org/r/56368/diff/ > > > Testing > ------- > > This is the last patch in a series. Applied all together, they were tested > with `make && make check` on Linux, and `support\windows-build.bat` on > Windows. All tests pass (minus flaky ones which sometimes fail but that's > unrelated). > > > Thanks, > > Andrew Schwartzmeyer > >
