----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56284/#review164539 -----------------------------------------------------------
src/tests/containerizer/provisioner_docker_tests.cpp (lines 241 - 242) <https://reviews.apache.org/r/56284/#comment236296> Maybe you should fix the comment. src/tests/containerizer/provisioner_docker_tests.cpp (lines 268 - 271) <https://reviews.apache.org/r/56284/#comment236295> Since you set `cached` as false and manually remove one layer from the store. This test only verifies that a missing layer will be pulled if `cached` is set as false. I do not see how it verifies the local puller will skip pullin the existing layers. - Gilbert Song On Feb. 6, 2017, 12:40 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56284/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 12:40 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-7045 > https://issues.apache.org/jira/browse/MESOS-7045 > > > Repository: mesos > > > Description > ------- > > The new test verifies that that local Docker puller and store will skip > layers that are already pulled. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > 99e0820fa47303896f70c81cfb91cd34f0474e55 > > Diff: https://reviews.apache.org/r/56284/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Ilya Pronin > >
