----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56341/ -----------------------------------------------------------
(Updated Feb. 7, 2017, 2:17 p.m.) Review request for mesos, Jie Yu and Kevin Klues. Changes ------- Moved the command executor changes into another review, to keep those logically separate. See https://reviews.apache.org/r/56410/ Bugs: MESOS-7027 https://issues.apache.org/jira/browse/MESOS-7027 Repository: mesos Description ------- This commit adds more special-casing in the `docker/runtime` isolator for the command executor. The command executor will generally break when the `docker/runtime` isolator provides environment variables directly to the executor. This is because the environment variables are provided in the context of the container image, rather than the host. For example, a container image may provide an environment variable like `LD_LIBRARY_PATH=/image/specific/location`, whereas the default executor expects to find libraries in the host's environment. If the image's environment end up in the command executor at launch time, the command executor may simply fail to launch. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/appc/runtime.cpp 9bc3fd8309435846c17944e74f611212069dbd76 src/slave/containerizer/mesos/isolators/docker/runtime.cpp 2d816e512c95ed2922c9578ba796908c5ce23da4 Diff: https://reviews.apache.org/r/56341/diff/ Testing ------- make check sudo src/mesos-tests --gtest_filter="*ROOT*" All the tests broken by https://reviews.apache.org/r/56339/ (earlier in the chain) are now passing. Thanks, Joseph Wu
