----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/#review164640 -----------------------------------------------------------
Maybe add a test to check master suppress/revive validation code path too? - Jay Guo On Feb. 7, 2017, 6:10 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56378/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 6:10 p.m.) > > > Review request for mesos, Benjamin Mahler and Jay Guo. > > > Bugs: MESOS-6638 > https://issues.apache.org/jira/browse/MESOS-6638 > > > Repository: mesos > > > Description > ------- > > Added test case for suppress and revive with multi role framework. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > c681d03c3f94f7d071143366a5aad0421108ebec > > Diff: https://reviews.apache.org/r/56378/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh > --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffersWithMultiRole" > --gtest_repeat=100 > ``` > > > Thanks, > > Guangya Liu > >
