> On Feb. 8, 2017, 9:44 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp, lines 352-353 > > <https://reviews.apache.org/r/56330/diff/2/?file=1626019#file1626019line352> > > > > This header doesn't use @param, we can just update the comment above: > > > > ``` > > Informs the allocator to stop sending offers to this framework for the > > specified role. If the role is not specified, we will stop sending offers > > to this framework for all of its roles. > > ```
Feel free to use @param, but be sure to update the overall comment for the function. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56330/#review164774 ----------------------------------------------------------- On Feb. 7, 2017, 10:10 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56330/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 10:10 a.m.) > > > Review request for mesos, Benjamin Mahler and Jay Guo. > > > Bugs: MESOS-6638 > https://issues.apache.org/jira/browse/MESOS-6638 > > > Repository: mesos > > > Description > ------- > > Enabled suppress offer per role. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 71a40537b673e44ecdd5327d9a9f083faa7fc13a > src/master/allocator/mesos/allocator.hpp > e3c86181677302dbfc3b213715196122f96e312c > src/master/allocator/mesos/hierarchical.hpp > 896abcdf0727f986eef3a1a9304a0e4847094057 > src/master/allocator/mesos/hierarchical.cpp > 56d6791baa64189523df668749f4a7ab67d6b363 > src/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a > src/tests/allocator.hpp 32c291213d18d1c8fe5d9e8194b92c10716b9961 > src/tests/hierarchical_allocator_tests.cpp > c681d03c3f94f7d071143366a5aad0421108ebec > > Diff: https://reviews.apache.org/r/56330/diff/ > > > Testing > ------- > > make > make check > > Will add a test case to enable suppress per role in follow up patches. > > > Thanks, > > Guangya Liu > >
