----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56370/#review164814 -----------------------------------------------------------
Ship it! src/tests/master_tests.cpp (lines 6343 - 6349) <https://reviews.apache.org/r/56370/#comment236606> Not sure why you need the `this->` here? - Michael Park On Feb. 6, 2017, 11:29 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56370/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 11:29 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. > > > Bugs: MESOS-7062 > https://issues.apache.org/jira/browse/MESOS-7062 > > > Repository: mesos > > > Description > ------- > > This test ensures that multi-role framework should receive offers for > each of its roles. > > > Diffs > ----- > > src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18 > > Diff: https://reviews.apache.org/r/56370/diff/ > > > Testing > ------- > > Added a test. > > make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers" > > > Thanks, > > Jay Guo > >
