----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56525/#review165161 -----------------------------------------------------------
Ship it! I tested as well and the segfault is gone. Re-ordering of delete's LGTM. - Greg Mann On Feb. 10, 2017, 5:34 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56525/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 5:34 a.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-7102 > https://issues.apache.org/jira/browse/MESOS-7102 > > > Repository: mesos > > > Description > ------- > > There were some actors that were not being destructed when > `finalize()` was being invoked. Also fixed the order of the > destruction of objects i.e., in the reverse order of their > creation. > > > Diffs > ----- > > src/slave/main.cpp b9f9748d98775b2a511ded35bbf72099bfeeba64 > > Diff: https://reviews.apache.org/r/56525/diff/ > > > Testing > ------- > > make check, manually tested to ensure we don't crash on a `SIGUSR1` signal. > > > Thanks, > > Anand Mazumdar > >
