> On Feb. 9, 2017, 9:38 p.m., Benjamin Mahler wrote: > > src/master/master.hpp, lines 2425-2451 > > <https://reviews.apache.org/r/56499/diff/1/?file=1628557#file1628557line2425> > > > > We need to update the newly introduced `roles` field here. Also, > > oldRoles can be removed in favor of directly accessing `roles`. > > Guangya Liu wrote: > Since we do not allow updating `roles` for frameworks and the `roles` was > already initialized when construct the framework, so do we still need to > update the `roles` here?
Ah right, dropping this. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56499/#review165008 ----------------------------------------------------------- On Feb. 10, 2017, 12:24 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56499/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 12:24 a.m.) > > > Review request for mesos, Benjamin Mahler and Jay Guo. > > > Bugs: MESOS-6638 > https://issues.apache.org/jira/browse/MESOS-6638 > > > Repository: mesos > > > Description > ------- > > Added roles field to framework. > > > Diffs > ----- > > src/master/master.hpp 767ac48f2a65514a19c4a3f8ca7b35f0259f9aeb > src/master/master.cpp 620919ecfe85367b5c1281afc5216cc20e5e2e3c > > Diff: https://reviews.apache.org/r/56499/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
