----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56392/#review165210 -----------------------------------------------------------
Looks good, you'll need to rebase this after you update your previous patch. src/tests/master_validation_tests.cpp (line 428) <https://reviews.apache.org/r/56392/#comment237027> Not yours, but we should take the backticks out the log message in a follow up. - Benjamin Mahler On Feb. 10, 2017, 3:16 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56392/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 3:16 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Repository: mesos > > > Description > ------- > > This change makes expected error strings in reservation > validation-related tests explicit. This is to make sure that the > observed errors match the expected ones. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 0c2649089d7fd29eb021ac75c71e6a74368577dc > > Diff: https://reviews.apache.org/r/56392/diff/ > > > Testing > ------- > > make check (OS X) > > > Thanks, > > Benjamin Bannier > >
