> On 二月 10, 2017, 9:27 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp, lines 2246-2247
> > <https://reviews.apache.org/r/56524/diff/1/?file=1629166#file1629166line2246>
> >
> > Can you follow the same format at the drop two lines above?
> >
> > ```
> > LOG(ERROR) << "Dropping " << call.type() << " call"
> > << " from framework " << *framework
> > << ": " << message;
> > ```
> >
> > Not yours, but just as an aside it seems like all of the drop logging
> > should probably be at the warning instead of error level. Feel free to
> > leave as is for now.
Added a `TODO` here to follow up the `WARNING` message.
```
// TODO(gyliu513): Update all `drop` logging to `WARNING`.
LOG(ERROR) << "Dropping " << call.type() << " call"
<< " from framework " << *framework
<< ": " << message;
```
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56524/#review165176
-----------------------------------------------------------
On 二月 10, 2017, 1:42 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56524/
> -----------------------------------------------------------
>
> (Updated 二月 10, 2017, 1:42 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jay Guo.
>
>
> Bugs: MESOS-6638
> https://issues.apache.org/jira/browse/MESOS-6638
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `drop` for overload to avoid custom logging.
>
>
> Diffs
> -----
>
> src/master/master.hpp 767ac48f2a65514a19c4a3f8ca7b35f0259f9aeb
> src/master/master.cpp 620919ecfe85367b5c1281afc5216cc20e5e2e3c
>
> Diff: https://reviews.apache.org/r/56524/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
