----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56587/#review165383 -----------------------------------------------------------
src/master/master.cpp (lines 4754 - 4768) <https://reviews.apache.org/r/56587/#comment237219> Moving the error above the CHECK leaves out the log message in one case: * ACCEPT_INVERSE_OFFER is called with multiple offers (invalid-offer-id and valid-offer-id). * In the processing loop, we will LOG(WARNING) for `invalid-offer-id`. * After the processing loop, we _should_ LOG(INFO) for `valid-offer-id` with the agent and framework info too. <-- This one is left out in your patch - Joseph Wu On Feb. 12, 2017, 9:44 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56587/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2017, 9:44 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-7119 > https://issues.apache.org/jira/browse/MESOS-7119 > > > Repository: mesos > > > Description > ------- > > The erroneous invariant check for `slaveId` can be trigerred when > the master accepts an invalid inverse offer or when the inverse offer > has been already rescinded. > > > Diffs > ----- > > src/master/master.cpp dff320acd1a13995d51cc0c303edea0cdfaa336d > src/tests/master_maintenance_tests.cpp > 9861d1186e046a4fd547e73825c02b71eedd5ce2 > > Diff: https://reviews.apache.org/r/56587/diff/ > > > Testing > ------- > > make check + added a test that used to crash before. > > > Thanks, > > Anand Mazumdar > >
