----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56611/#review165400 -----------------------------------------------------------
src/linux/perf.hpp (line 60) <https://reviews.apache.org/r/56611/#comment237230> This parameter should be named. src/linux/perf.cpp (line 212) <https://reviews.apache.org/r/56611/#comment237232> Can we be more specific than just saying "lax manner"? src/linux/perf.cpp (line 227) <https://reviews.apache.org/r/56611/#comment237233> Needs `#include <algorithm>` for `std::min`. Also, I think `size_t` would be more idiomatic than `unsigned`. src/linux/perf.cpp (line 234) <https://reviews.apache.org/r/56611/#comment237234> The logic here seems a bit strained. Wouldn't it be simpler to just say: (a) we parse at most the first three components of the version, (b) return an error if either of the first two components can't be parsed and default to zero for third component. src/linux/perf.cpp (line 235) <https://reviews.apache.org/r/56611/#comment237231> Whitespace before `+`, also after `:`. - Neil Conway On Feb. 13, 2017, 8:11 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56611/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 8:11 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-6982 > https://issues.apache.org/jira/browse/MESOS-6982 > > > Repository: mesos > > > Description > ------- > > Relax perf version check for Arch Linux. > > > Diffs > ----- > > src/linux/perf.hpp 9c4330b6086abb18f036222260fe89a6fb01d8ed > src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb > src/tests/containerizer/perf_tests.cpp > d536ecc5cb24787bc3487efb146573cd4f3ded43 > > Diff: https://reviews.apache.org/r/56611/diff/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
