----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56645/#review165477 -----------------------------------------------------------
src/common/http.hpp (lines 123 - 130) <https://reviews.apache.org/r/56645/#comment237328> Let's try to keep this alphabetized. src/slave/http.cpp (lines 1246 - 1247) <https://reviews.apache.org/r/56645/#comment237329> I see we have a type `SlaveInfo::Capability` defined, but don't store any values there. Shouldn't we have a repeated field there (similar to what we currently have for e.g., agent attributes, instead of synthetizing something on the spot here? - Benjamin Bannier On Feb. 14, 2017, 8:13 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56645/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 8:13 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and > Michael Park. > > > Bugs: MESOS-6902 > https://issues.apache.org/jira/browse/MESOS-6902 > > > Repository: mesos > > > Description > ------- > > Added agent capabilities to `/state`(v0) endpoint of agent. > > > Diffs > ----- > > src/common/http.hpp 3d5ab59ddc4dce4d791c1b439f5e1459d1a724a4 > src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e > src/master/http.cpp caa1fabb7a709d993ff711cc7803dd05000fa987 > src/slave/http.cpp ccd489d700a605dc41037e00dbd6a7cb3b6edcc6 > src/tests/slave_tests.cpp b6f76824c20c842d8f1d8afb1f9b81668b6741da > > Diff: https://reviews.apache.org/r/56645/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
