----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56652/ -----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Repository: mesos Description ------- Currently, compiling against ZK on Windows will cause many macro redefinition errors. This occurs because ZK has a `winstdint.h` file, which contains definitions for macros that historically have not existed in the MSVC toolchain. However, since MSVC 1900, many of these now exist. Here, we introduce a patch file that will condition out these definitions for versions 1900 and later. Additionally, the previous patch file was not fully correct, resulting in the patch being "fuzzed" when it was applied. This patch generates the correct output, allowing the patches to apply cleanly. Diffs ----- 3rdparty/zookeeper-06d3f3f.patch be2ceaf529895c92dcf53984d6d88c78fb1d74ec Diff: https://reviews.apache.org/r/56652/diff/ Testing ------- Thanks, Alex Clemmer
