----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/#review165509 -----------------------------------------------------------
This look great already. But I'll need more time to deeply review this, e.g. I'll do another round, this are the few things I found while quickly looking over the patch. src/files/files.cpp (line 800) <https://reviews.apache.org/r/56619/#comment237351> Remove the space between `context` and `)`. src/master/master.cpp (line 1613) <https://reviews.apache.org/r/56619/#comment237349> Check for `context.isSome()` first. src/master/weights_handler.cpp (line 369) <https://reviews.apache.org/r/56619/#comment237350> Remove `<< context.get()` here. - Jan Schlicht On Feb. 14, 2017, 1:14 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56619/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 1:14 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP endpoint handlers in Mesos > to accept an `AuthenticationContext` instead of an > `Option<string>& principal`. > > > Diffs > ----- > > src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e > src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a > src/master/http.cpp c5324abc0db82275fd65d3f7d361ad8ee9e017d1 > src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e > src/master/master.cpp dff320acd1a13995d51cc0c303edea0cdfaa336d > src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a > src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 > src/master/weights_handler.cpp da0b995e1866e7eb57b8ef885864c6c6d66405d6 > src/slave/http.cpp ccd489d700a605dc41037e00dbd6a7cb3b6edcc6 > src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 > src/slave/slave.cpp ebba8e16bc9ec45781183e78cb5a3c351a5f65f5 > > Diff: https://reviews.apache.org/r/56619/diff/ > > > Testing > ------- > > Testing information can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
