> On Feb. 14, 2017, 11:24 p.m., Joseph Wu wrote: > > src/docker/docker.hpp, lines 41-47 > > <https://reviews.apache.org/r/56505/diff/3/?file=1633524#file1633524line41> > > > > This isn't a default, as you can't change the value without breaking it.
Per offline conversation, this actually is the default host prefix, as Windows Containers supports either `npipe://` or `tcp://`. We've agreed to add a comment to clarify, but keep the name as is. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56505/#review165583 ----------------------------------------------------------- On Feb. 14, 2017, 7:06 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56505/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 7:06 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-3098 > https://issues.apache.org/jira/browse/MESOS-3098 > > > Repository: mesos > > > Description > ------- > > This commit will introduce the changes to the Mesos Docker interfaces > required to use the Docker executor to run Windows Containers in the > Mesos agent. In particular, since Windows Containers use named pipes to > connect do the Docker host, rather than a socket, we introduce the > plumbing to default to a named pipe connection when invoking the > `docker` command. > > This work constitutes the beginning of the end of the work that will > eventually result in Mesos support of Windows Containers. > > This review is partially based on r/52364, which was the work of Daniel > Pravat. > > Lastly, this review has a planned regression in MESOS-6816. In other > parts of the codebase, we copy all environment variables from the system > before launching a process, overwriting user specified environment > variables. This is not correct behavior, but a half-measure that is > necessary, because Windows does not inherit environment variables by > default. In this commit, we make this behavior uniform across all places > where we are creating a process, because it is better for behavior to be > consistent before we get around to fixing it. We do have concrete plans > to come back and resolve this issue. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/slave/constants.hpp 1159ac3b1f8797a847a6f5679045434064a519e9 > src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d > src/slave/containerizer/mesos/launch.hpp > 49eb9128ae5a1e4ec02e2b9d9e3cb67d7a8f7663 > src/slave/containerizer/mesos/launch.cpp > 4dd81b47ca4654f5e783a4f2227834e938bc8bb3 > src/slave/flags.cpp 71935dea0f898d4594de9a5d8a3d1c7fc1a21606 > src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906 > > Diff: https://reviews.apache.org/r/56505/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
