----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56716/#review165741 -----------------------------------------------------------
Fix it, then Ship it! src/tests/default_executor_tests.cpp (line 1238) <https://reviews.apache.org/r/56716/#comment237592> s/update/update for each task/ s/next update/next updates/ src/tests/default_executor_tests.cpp (line 1305) <https://reviews.apache.org/r/56716/#comment237622> kinda orthogonal to this fix, but i'm wondering if executor should exit with a non-zero status if any of its tasks exits with non-zero. - Vinod Kone On Feb. 15, 2017, 6:28 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56716/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 6:28 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7129 > https://issues.apache.org/jira/browse/MESOS-7129 > > > Repository: mesos > > > Description > ------- > > There was an incorrect assumption when kiling a task group that > all its other tasks would still be active. Its possible that > some of them terminated successfully earlier. > > > Diffs > ----- > > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > src/tests/default_executor_tests.cpp > 1afab8292c7fc15bd16bee4bcd93ce290a233c9a > > Diff: https://reviews.apache.org/r/56716/diff/ > > > Testing > ------- > > make check + added test > > > Thanks, > > Anand Mazumdar > >
