-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56594/#review165893
-----------------------------------------------------------


Ship it!




Effectively the same as: https://reviews.apache.org/r/56237/

So I'll close both and attribute the patch to Anthony.

- Joseph Wu


On Feb. 16, 2017, 2:58 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56594/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2017, 2:58 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6138
>     https://issues.apache.org/jira/browse/MESOS-6138
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `protoc` will complain about `.proto` files that do not explicitly
> specify the version of PB syntax they're using. On Windows, this
> registers as a build warning.
> 
> To ameliorate this, we explicitly specify the syntax in all `.proto`
> files.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/protobuf_tests.proto 
> 229ac256b087d55ecc95636254261ecd12829187 
> 
> Diff: https://reviews.apache.org/r/56594/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to