> On Feb. 16, 2017, 10:56 a.m., Alexander Rojas wrote: > > src/common/http.cpp, line 708 > > <https://reviews.apache.org/r/56618/diff/1/?file=1632575#file1632575line708> > > > > I have the feeling that `extractAuthorizationSubject` may be a better > > way of describing what is happening here. > > > > I wonder if there is a way of introducing this to the protobuf > > generated `Subject` class so this is not a free function.
I'm not really a fan of `extractAuthorizationSubject`, since there isn't an actual `authorization::Subject` within the context type, we're constructing a new one and returning it. I don't think it's worth messing with the protobuf classes to avoid a free function. I'll namespace the creation functions to improve the isolation. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review165825 ----------------------------------------------------------- On Feb. 13, 2017, 11:46 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56618/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 11:46 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates common Mesos HTTP-related helpers, > as well as the `authorization::Subject` protobuf > message, to make use of the `AuthenticationContext` > type instead of an `Option<string> principal`. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > 8b860a3e8e0b1c660a8fefc97f10f5acc0501920 > src/common/http.hpp 3d5ab59ddc4dce4d791c1b439f5e1459d1a724a4 > src/common/http.cpp abfbf7248beb2d4068be06b7f5f829d7617f943e > > Diff: https://reviews.apache.org/r/56618/diff/ > > > Testing > ------- > > Testing information can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
