----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/#review166054 -----------------------------------------------------------
3rdparty/stout/include/stout/base64.hpp (lines 174 - 177) <https://reviews.apache.org/r/56665/#comment237957> Could you include a comment here describing the `padding` parameter? 3rdparty/stout/include/stout/base64.hpp (line 175) <https://reviews.apache.org/r/56665/#comment237955> s/an URL/a URL/ 3rdparty/stout/include/stout/base64.hpp (line 185) <https://reviews.apache.org/r/56665/#comment237956> s/an URL/a URL/ - Greg Mann On Feb. 16, 2017, 9:33 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56665/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 9:33 a.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > Base64 has many variants that use different alphabets for encoding. > "Base 64 Encoding with URL and Filename Safe Alphabet" is a variant > described in RFC 4648. > > > Diffs > ----- > > 3rdparty/stout/include/stout/base64.hpp > 2ac04c4602bc919633a2a480dd2168b7aa301bd7 > 3rdparty/stout/tests/base64_tests.cpp > 32e516861d44c7e3a36e1a29b4d1fe5960684e3b > > Diff: https://reviews.apache.org/r/56665/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
