----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56814/#review166124 -----------------------------------------------------------
Ship it! Good catch! - Jie Yu On Feb. 18, 2017, 6:40 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56814/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2017, 6:40 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-7144 > https://issues.apache.org/jira/browse/MESOS-7144 > > > Repository: mesos > > > Description > ------- > > Since the IOSwitchboard is implemented as a MesosIsolatorProcess, most > of its API calls are automatically dispatched onto its underlying > process by an Isolator wrapper. However, the IOSwitchboard also > includes an additional connect() call which is not accessed through > the Isolator wrapper. As such, we need to wrap it in a dispatch call > manually. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.hpp > 7a7ad2da047ef316f4382e45526d503c87a903a0 > src/slave/containerizer/mesos/io/switchboard.cpp > b948f3c44dd2e1af2228ca1579f24ae3a94160b0 > > Diff: https://reviews.apache.org/r/56814/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check > sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
