----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56833/#review166235 -----------------------------------------------------------
Can you add unit tests for the validation? src/master/validation.cpp (line 883) <https://reviews.apache.org/r/56833/#comment238139> don't you want to return error here? - Vinod Kone On Feb. 20, 2017, 5:01 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56833/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2017, 5:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added validation for on termination policy to the master. > > > Diffs > ----- > > src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f > > Diff: https://reviews.apache.org/r/56833/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
