----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56675/#review166017 -----------------------------------------------------------
I'm going to review/commit this patch in a piece-meal fashion, as some of these warnings expose actual edge cases, while others can be committed directly (or with slight tweaks). src/CMakeLists.txt (lines 128 - 134) <https://reviews.apache.org/r/56675/#comment238191> This one looks good. I can pull it out and commit it with a fleshed out commit description. src/common/values.cpp (lines 76 - 77) <https://reviews.apache.org/r/56675/#comment237908> This is actually an `streamsize`. Instead of casting, we could just use the correct type. src/common/values.cpp (lines 610 - 618) <https://reviews.apache.org/r/56675/#comment237910> This is some very odd casting... (and apparently it originates from the original code mirrored from the SVN repo by BenH...) We could just get rid of the `j` variable. src/files/files.cpp (line 665) <https://reviews.apache.org/r/56675/#comment238184> I'm going to create a separate patch chain to see if this is worth a wider fix. At the moment, if you try to pass in an offset/length like `9223372036854775808` (2^63), depending on the code path, you'll get different results. For the `/files/read?` codepath, you get: ``` Failed to parse offset: Failed to convert '9223372036854775808' to number. ``` For the V1 API, this query would return a 200, with no data. All code paths should reject values that large. Continued in: https://reviews.apache.org/r/56906/ - Joseph Wu On Feb. 14, 2017, 10:40 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56675/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 10:40 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Silence MSVC compiler warnings in libmesos. > > > Diffs > ----- > > src/CMakeLists.txt 3a4ace9c8011ac8eec5067cd085fa7fe4166b9ee > src/common/values.cpp cb26627bb79e0c952e5fb5d216264719199372d3 > src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > src/master/allocator/sorter/drf/sorter.cpp > ae49fcd659972f984238f8f90aa395e345bfaaa6 > src/master/master.hpp 32915d049a2d91d648b7d33c15ef50c8bc0c72cd > src/master/master.cpp 0b65345d48192a1536d43973cf782ade3c1c8163 > src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 > src/slave/constants.cpp dbd2ecb146f288a4dec50bf041768fd5c4b3cb72 > src/slave/containerizer/mesos/containerizer.cpp > d2b4f75a55dbe4746bc2dfc180335fa831a554ef > src/slave/containerizer/mesos/isolators/posix.hpp > 627004663cbd7223a252b875c51454a20e645be6 > src/slave/containerizer/mesos/launcher.cpp > 5114c130efbfb252dde1e85c081f5174e66f57af > src/slave/slave.cpp ebba8e16bc9ec45781183e78cb5a3c351a5f65f5 > src/tests/hook_tests.cpp 237df8102941cd143c4d61016963e62a69c43382 > src/tests/partition_tests.cpp 105157deaa500642a490b8bda0624629035a95a5 > src/tests/protobuf_io_tests.cpp 82bffb814a979eceb46531f981053495c7b2bdbc > src/tests/resources_tests.cpp 2bdce3c496108a66308ab6c8484dd171cc6c019f > src/tests/scheduler_tests.cpp 1ff423fd5abaffc0e6a0f7fb0edc3e1d5c85fb59 > src/tests/slave_tests.cpp b6f76824c20c842d8f1d8afb1f9b81668b6741da > src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba > src/zookeeper/zookeeper.cpp 5ede4e5c47b30693ef9f296777dea8db2c4a48d8 > > Diff: https://reviews.apache.org/r/56675/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
